Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rather important change from the refactoring standpoint, but sees almost no improvement from the user's PoV. In fact, the operators aren't available as functions anymore, which requires using special code if one wants to use them as such.
For the VM, however, this means eliminating a lot of
vmThrowErrors, which were there because the arity of operators wasn't guaranteed at callsite. Right now the parser call information is properly preserved right until the call.This also required moving all the operator code to
Eval.Eval. While this made the module grow significantly, I don't think it's such a huge issue in the end. Operators now being core parts of the language really don't belong in the outer modules, and it was just that much easier to implement them there.There are still a few things left to polish, namely fixing the comparison parser test, fixing names for internal op impl functions and some other small changes.