fix: suppress JSONDecodeError chain on empty HTTP 429 - #558
Open
alexander-nikitin-thenvoi wants to merge 5 commits into
Open
fix: suppress JSONDecodeError chain on empty HTTP 429#558alexander-nikitin-thenvoi wants to merge 5 commits into
alexander-nikitin-thenvoi wants to merge 5 commits into
Conversation
Add a red-on-purpose pytest that hits get_agent_me through the real BandLink REST client with an ALB-style empty 429 body. Asserts the raised ApiError has no JSONDecodeError in __cause__/__context__ and no JSONDecodeError in the formatted traceback. Co-authored-by: Alexander Nikitin <alexander-nikitin-thenvoi@users.noreply.github.com>
Surface the dual JSONDecodeError/ApiError traceback in the pytest failure message so the #108 symptom is visible in the red run. Co-authored-by: Alexander Nikitin <alexander-nikitin-thenvoi@users.noreply.github.com>
band-client-rest==0.0.26 (and 0.0.28) re-raises ApiError from JSONDecodeError without from None when get_agent_me sees an empty error body. Wrap that generated method so callers get a clean ApiError. Co-authored-by: Alexander Nikitin <alexander-nikitin-thenvoi@users.noreply.github.com>
Pyrefly rejects assigning a generic wrapper onto the generated get_agent_me signature; setattr keeps the same pin-tied wrap. Co-authored-by: Alexander Nikitin <alexander-nikitin-thenvoi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSONDecodeError traceback shown on empty 429 response bodies (#108)
Turns QA PR #557's test green. Empty ALB-style HTTP 429 (
Content-Length: 0) onBandLink→agent_api_identity.get_agent_menow raises a cleanApiErrorwith noJSONDecodeErrorin__cause__/__context__and no intermediate traceback.Changes
band-client-rest==0.0.26(and 0.0.28) stillraise ApiError(...)fromJSONDecodeErrorwithoutfrom Nonein generatedget_agent_me. Bumping the pin does not fix this.get_agent_mere-raises thatApiErrorwithfrom None. Does not change Fern 429 retry behavior.Related Issues
Fixes #108
Testing
uv run pytest tests/platform/test_rest_empty_429.py -v --no-cov(QA test: fail on JSONDecodeError chain from empty 429 (#108) #557 test; red-to-green)uv run pytest tests/test_platform_runtime.py::TestStart::test_retries_metadata_fetch_on_rate_limit -v --no-covuv run pytest tests/ --ignore=tests/integration/ --ignore=tests/e2e/— 4875 passed, 122 skipped)Checklist