Fixed a bunch of small Ropenbt R package issues. - #56
Merged
Conversation
Synchronize Feature Branch
jared321
reviewed
Jul 27, 2026
jared321
left a comment
jared321
left a comment
Contributor
There was a problem hiding this comment.
If you change Ropenbt/LICENSE from a file to a symlink to the LICENSE file in the root of the repo, will the R packaging system include the license file correctly?
This is what I do for the Python package so that we (hopefully) only have to manage one license file.
Collaborator
Author
|
I would guess so, can try it. I should do ln -s ? |
Contributor
|
That is what I have done in the past. |
Collaborator
Author
|
Ok I fixed this and pushed. |
jared321
approved these changes
Jul 28, 2026
jared321
left a comment
jared321
left a comment
Contributor
There was a problem hiding this comment.
- Reviewed all changes
- Confirm all actions passing
The latter was just a formality since we don't have any R actions yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.