Update 161CoverageFix#168
Merged
jared321 merged 32 commits into161CoverageFixfrom Sep 9, 2025
Merged
Conversation
The source distribution build/test job did indeed cause action to fail as expected.
The macOS 14 build wheel action did indeed cause the action to fail as expected.
setuptools-scm uses tags in the project's clone to automatically determine the version. It appears that the default shallow clone did not include tags. This fix was present in publish.yml, which suggests that release.yml will hopefully build distributions with the correct version.
The wheels were building with the expected version string in the GH action.
See if loading this file is the source of mixed carriage returns in Windows wheels.
Also, reset to windows-latest runner. Using newer OS didn't help.
Ran tox tasks locally and all passed.
Build distributions action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for PR #162, we need to merge into the branch all changes made to
mainsince this branch was created off ofmain.