Skip to content

adding user input emulator variance for nuclear-ROSE#75

Merged
wildsm merged 11 commits intov0.2-stagingfrom
nuclear-rose-emu-var-input
Sep 18, 2023
Merged

adding user input emulator variance for nuclear-ROSE#75
wildsm merged 11 commits intov0.2-stagingfrom
nuclear-rose-emu-var-input

Conversation

@mosesyhc
Copy link
Copy Markdown
Member

No description provided.

@mosesyhc mosesyhc changed the base branch from main to v0.2-staging September 14, 2023 03:08
@wildsm
Copy link
Copy Markdown
Contributor

wildsm commented Sep 14, 2023

I realize this is in draft mode, but is there an example to test? For example, if the variance is provided must it be nonnegative or positive? Is this checked?

@mosesyhc
Copy link
Copy Markdown
Member Author

There is currently a local jupyter notebook that tests the use of this wrapper. The ROSE group is working on tutorials in the form of jupyter notebooks.

Variance input is not currently checked. But that is an excellent point. I will add an assertion.

@mosesyhc
Copy link
Copy Markdown
Member Author

A bigger question though is how should one test such integration. ROSE software tests the emulator and surmise tests several steps of an MCMC chain? This is an emulator that does not look like any of the GP ones.

@wildsm
Copy link
Copy Markdown
Contributor

wildsm commented Sep 15, 2023

A bigger question though is how should one test such integration. ROSE software tests the emulator and surmise tests several steps of an MCMC chain? This is an emulator that does not look like any of the GP ones.

Yes, I think surmise would test something with nontrivial input (e.g., a brief MCMC) and then the downstream user, rose, would test their basic case to identify whether surmise (the upstream dependency) has broken something since the last test.

@mosesyhc
Copy link
Copy Markdown
Member Author

@wildsm:
A test notebook that calls nuclear-ROSE in surmise is available at: https://github.com/bandframework/rose/blob/develop/tutorials/ROSE_tutorial_2_optical_potential_surmise_UQ.ipynb

@mosesyhc mosesyhc requested a review from wildsm September 18, 2023 16:15
@mosesyhc mosesyhc marked this pull request as ready for review September 18, 2023 16:15
@wildsm wildsm merged commit 1c5ddea into v0.2-staging Sep 18, 2023
@wildsm wildsm deleted the nuclear-rose-emu-var-input branch September 18, 2023 16:35
@mosesyhc mosesyhc restored the nuclear-rose-emu-var-input branch September 19, 2023 14:00
@mosesyhc
Copy link
Copy Markdown
Member Author

@wildsm : one ROSE notebook for a seminar today refers to this branch - will remove branch completely after.

@mosesyhc mosesyhc deleted the nuclear-rose-emu-var-input branch September 23, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants