dedup backend: Fix leaking filedescriptor

[sebsura]

Backport of PR #2548 to bareos-24

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General

• Correct milestone is set

Source code quality (if there were changes to the original PR)

• Source code changes are understandable
• Variable and function names are meaningful
• Code comments are correct (logically and spelling)
• Required documentation changes are present and part of the PR

Backport quality

• Original PR dedup backend: Fix leaking filedescriptor #2548 is merged
• All functional differences to the original PR are documented above

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 010389e0-8e83-49f0-becb-c61e4c85f055

📥 Commits

Reviewing files that changed from the base of the PR and between 7c3c8ab and f38d67c.

📒 Files selected for processing (2)

• CHANGELOG.md
• core/platforms/freebsd/bareos-freebsd/bareos.com-common/BareosCommonMakefile

---

📝 Walkthrough

Walkthrough

Refactors descriptor handling in the dedupable backend: raii_fd API tightened (explicit ctor, noexcept move/assign, const/noexcept accessors, operator bool() explicit, fd made private), and volume now stores and uses raii_fd instead of raw int; OpenRelative returns raii_fd.

Changes

Cohort / File(s)	Summary
RAII Wrapper core/src/stored/backends/dedupable/util.h	Tightened API: explicit raii_fd(int) noexcept; move ctor/assign marked noexcept; fileno() → int fileno() const noexcept; release() → int release() noexcept; operator bool() → explicit operator bool() const noexcept; fd moved to private.
Volume integration core/src/stored/backends/dedupable/volume.h, core/src/stored/backends/dedupable/volume.cc	Replaced raw directory fd (int) with raii_fd; OpenRelative now returns raii_fd; call sites updated to use .fileno() and propagate the RAII wrapper; error contexts adjusted for wrapped descriptors.
Changelog CHANGELOG.md	Added "dedup backend: Fix leaking filedescriptor [PR #2550]" under Unreleased and referenced PR #2550.
Platform makefile core/platforms/freebsd/.../BareosCommonMakefile	PLIST_SUB DISTVERSION extraction regex changed to capture semantic version pattern (([0-9]+\.){2}[0-9]+).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• dedup backend: Fix leaking filedescriptor #2548 — Same raii_fd declaration changes and volume refactor to use raii_fd.
• dedup backend: Fix leaking filedescriptor #2551 — Modifies raii_fd and updates volume.{cc,h} to propagate RAII wrapper.
• dedup backend: Fix leaking filedescriptor #2550 — Related fix addressing file-descriptor leak in dedup backend; referenced in changelog.

Suggested reviewers

• pstorz

Suggested labels

requires backport to 23

Poem

🐰 I hopped in code with nimble paws,
Wrapped stray fds and tamed their flaws,
Explicit, noexcept, tucked away,
Private fd now saves the day,
A tiny hop — no leaks, applause! 🎩

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	PR description is incomplete and missing critical required sections from the template.	Add a concise summary of changes above the checklist and verify the PR title is usable as a CHANGELOG entry. Document the purpose and scope of the backport clearly.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title 'dedup backend: Fix leaking filedescriptor' directly and clearly describes the main change: fixing a file descriptor leak in the dedup backend, which aligns with the commit messages and code changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}