feat: add QR scan tab to drawer QR sheet#500
Merged
Merged
Conversation
Adds a Scan tab alongside Nostr/Lightning in the drawer's QR sheet that opens the camera and decodes Nostr entities (npub, note, nprofile, nevent, naddr) — with or without the nostr: prefix — and navigates directly to the matching profile, thread, or article. Extracts the camera scanner from WalletScreen into a reusable QrScanner component, and centralizes NostrUriData→route mapping as toRoute() in Navigation.kt so the deep-link handler and scanner share it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npub,note,nprofile,nevent,naddr), with or without thenostr:prefix, and navigates directly to the matching profile / thread / article.QrScannercomponent shared by the wallet and the drawer.NostrUriData→ route mapping inNavigation.ktso the deep-link handler and the scanner share a single implementation.Test plan
JAVA_HOME=~/Downloads/android-studio/jbr ./gradlew installDebugnpub1…QR → lands on profilenote1,nprofile1,nevent1, andnaddr1(kind 30023)nostr:prefix stripped → same behavior