Fix spacing after dotted abbreviations - #370
Merged
Merged
Conversation
bartekplus
marked this pull request as ready for review
July 27, 2026 19:58
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8017f118bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #365
Root cause
The technical-token heuristic treated the final segment of a dotted abbreviation as a chained code accessor. When the next character was typed after the trailing space, it compacted
. ato.aand removed the user's space.Behavior choice
Dotted prose and accessor chains are indistinguishable from text alone. The rule now preserves the authored space for all dotted words, including
a.m.,e.g.,z.B.,m.in., and accessor-looking input such asa.b. c. Numeric forms such as3. 14and12: 30are still compacted.Validation
bun run checkbun run test(1,526 passed)bun run check:e2e:coveragebun run test:e2e(Chrome: 26 passed)bun run test:e2e --platform=firefox(26 passed)bun run test:e2e:full(Chrome: 64 passed, 7 expected skips)bun run test:e2e:full --platform=firefox(64 passed, 7 expected skips)