fix: Ensure appropriate quoting for case sensitive tenant names#101
Merged
bartventer merged 2 commits intomasterfrom Jul 11, 2025
Merged
fix: Ensure appropriate quoting for case sensitive tenant names#101bartventer merged 2 commits intomasterfrom
bartventer merged 2 commits intomasterfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Owner
Author
|
Tests fail as expected for
|
Fixes case-sensitive tenant name handling by using GORM's `QuoteTo` method instead of string concatenation for `SET search_path` and `USE` statements.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 81.22% 81.25% +0.02%
==========================================
Files 35 35
Lines 1273 1275 +2
==========================================
+ Hits 1034 1036 +2
Misses 190 190
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bartventer
commented
Jul 11, 2025
Owner
Author
bartventer
left a comment
There was a problem hiding this comment.
Reviewed and approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes case-sensitive tenant name handling in PostgreSQL and MySQL drivers by properly quoting schema and database names in path operations.
Changes
QuoteTo()inSetSearchPath()functionQuoteTo()inUseDatabase()functionTestIssue100comments below)Fixes #100