PolicyRegistry: drop ChildPoliciesOutsideOfRange args, add composite child-count getters - #190
Merged
Merged
Conversation
…, add composite child-count getters Removes the (min, max) args from ChildPoliciesOutsideOfRange and exposes the composite child-policy bounds instead via new MIN_COMPOSITE_CHILD_POLICIES()/MAX_COMPOSITE_CHILD_POLICIES() view functions on IPolicyRegistry, satisfied by MockPolicyRegistry. Co-Authored-By: Claude <noreply@anthropic.com>
rayyan224
requested review from
amiecorso,
eric-ships,
ilikesymmetry and
stevieraykatz
as code owners
August 4, 2026 19:29
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🔴 B20FactoryLib.sol | 95.40% | 96.00% | 100.00% | 90.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.54% | 97.67% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 96.80% | 97.29% | 98.14% | 96.49% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
rayyan224
commented
Aug 4, 2026
… public getters only MockPolicyRegistry no longer needs both an internal constant and a public alias for the composite child-policy bounds — MIN_COMPOSITE_CHILD_POLICIES/MAX_COMPOSITE_CHILD_POLICIES are now the single source of truth. Co-Authored-By: Claude <noreply@anthropic.com>
|
stevieraykatz
approved these changes
Aug 5, 2026
Collaborator
Author
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(min, max)args fromIPolicyRegistry.ChildPoliciesOutsideOfRange; it now reverts with no args.IPolicyRegistry:MIN_COMPOSITE_CHILD_POLICIES()andMAX_COMPOSITE_CHILD_POLICIES(), so the valid composite child-count range is discoverable via a call instead of parsed from the error args.MockPolicyRegistryimplements the new getters aspublic constants aliasing the existingMIN_CHILD_POLICIES/MAX_CHILD_POLICIESinternal constants (same pattern already used forALWAYS_ALLOW_ID/ALWAYS_BLOCK_ID), and both revert sites (createCompositePolicy,updateComposite) now throw the argless error.PolicyRegistryunit tests' revert expectations/NatSpec to match, and addscompositeChildPolicyLimits.t.solcovering the two new getters.Test plan
forge build— compiles clean,MockPolicyRegistrystill satisfiesIPolicyRegistryforge test --match-path "test/unit/PolicyRegistry/*"— 135 passed, 0 failedforge test(full suite) — 715 passed, 0 failed