docs(ifeevault): add initialization guard requirements to interface NatSpec#370
Open
dev-khimesh wants to merge 1 commit into
Open
docs(ifeevault): add initialization guard requirements to interface NatSpec#370dev-khimesh wants to merge 1 commit into
dev-khimesh wants to merge 1 commit into
Conversation
Documents initialization guard requirements for proxy pattern security. Closes base#363.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents the requirement for implementing contracts of
IFeeVaultto include initialization guards to prevent Uninitialized Proxy/Implementation Front-running attacks.Changes
IFeeVault.solinterface_disableInitializers()in constructor,initializermodifier, access control oninitialize()Note: The actual
FeeVault.solimplementation already has these guards in place (_disableInitializers()in constructor +initializermodifier). This PR just documents the requirement at the interface level.Closes #363