fix(readme): add LICENSE and repair license badge link - #1931
Open
kutluhaneth46 wants to merge 1 commit into
Open
fix(readme): add LICENSE and repair license badge link#1931kutluhaneth46 wants to merge 1 commit into
kutluhaneth46 wants to merge 1 commit into
Conversation
The README license badge pointed at blob/main/LICENSE.md, which 404s because the default branch is master and no license file existed. Add the same MIT LICENSE used by base/node and point the badge at it. Fixes base#1921
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blob/main/LICENSE.md, which 404s (Ref is invalid+ missing file).master, and the repo had no license file.LICENSEused bybase/node, and points the badge atblob/master/LICENSE.Test plan
LICENSEonmasterFixes #1921