-
Notifications
You must be signed in to change notification settings - Fork 380
New privacy policy banner #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
a463bf6 to
45de42b
Compare
5c55b19 to
24cf0e3
Compare
dgca
approved these changes
Jul 1, 2025
Elishaokon13
pushed a commit
to Elishaokon13/Base-docs
that referenced
this pull request
Jul 2, 2025
* New privacy policy banner * removing logs * fix link * fixes * ensure link doesn't wrap * update banner for all top level pages * update banner content * update banner text and update more pages with banner * adding to learn * add to more pages * updating more pages
ericbrown99
pushed a commit
that referenced
this pull request
Jul 2, 2025
* Update dependencies in package-lock.json and enhance wallet connection options in CafeUnitTest component - Updated versions of `brace-expansion` and `pbkdf2` packages in package-lock.json. - Added `metaMask` and `injected` wallet connectors to the CafeUnitTest component. - Modified wallet connection UI to include a modal display for wallet options. This commit improves wallet integration and ensures the project uses the latest package versions. * Fix typo in iframe source URL in erc-721-exercise.mdx * Enhance CafeUnitTest component styles and update iframe source URL in erc-721-exercise.mdx - Updated iframe source URL to point to localhost for local development. - Improved input and message styles in CafeUnitTest component for better user experience. - Added new styles for container, card, title, and wallet section to enhance visual appeal. - Adjusted button and input styles for improved interaction feedback. This commit focuses on refining the UI and ensuring the iframe points to the correct local resource. * Update iframe source URL in erc-721-exercise.mdx to point to Chromatic for live preview - Changed iframe source URL from localhost to a Chromatic URL for better accessibility during development. - This update ensures that the iframe displays the latest version of the CafeUnitTest component in a live environment. This commit focuses on improving the development workflow by providing a reliable source for the iframe content. * Remove autogenerated yarn.lock file - Deleted the yarn.lock file as it is autogenerated and should not be edited directly. - This change helps maintain a clean project structure by removing unnecessary files. This commit focuses on ensuring that the project does not include autogenerated files that can lead to confusion during development. * change link (#59) * Update discord links (#63) * update discord links * change cdp to buildonbase link * Add verified commit for merge requirements * Test verified commit signing * New privacy policy banner (#53) * New privacy policy banner * removing logs * fix link * fixes * ensure link doesn't wrap * update banner for all top level pages * update banner content * update banner text and update more pages with banner * adding to learn * add to more pages * updating more pages * Test commit signing * Clean up test file * Test SSH signing after configuration --------- Co-authored-by: youssea <youcefea99@gmail.com> Co-authored-by: xtbase <teaonbase@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
We are not using global
bannerconfig b/c it messes up the styling and truncates too early, hard to configureHow has it been tested?