Fix MetaMask Connection Issue in CafeUnitTest Component #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
ericbrown99
requested changes
Jun 30, 2025
ericbrown99
approved these changes
Jul 1, 2025
ericbrown99
approved these changes
Jul 1, 2025
Collaborator
|
Hey @Elishaokon13, commits need to be verified to be merged. Could you please implement and add a new commit which is verified. Then I can merge: https://docs.github.com/en/authentication/managing-commit-signature-verification |
Contributor
Author
I have added a verified commit, you can go ahead with merging |
…n options in CafeUnitTest component - Updated versions of `brace-expansion` and `pbkdf2` packages in package-lock.json. - Added `metaMask` and `injected` wallet connectors to the CafeUnitTest component. - Modified wallet connection UI to include a modal display for wallet options. This commit improves wallet integration and ensures the project uses the latest package versions.
… erc-721-exercise.mdx - Updated iframe source URL to point to localhost for local development. - Improved input and message styles in CafeUnitTest component for better user experience. - Added new styles for container, card, title, and wallet section to enhance visual appeal. - Adjusted button and input styles for improved interaction feedback. This commit focuses on refining the UI and ensuring the iframe points to the correct local resource.
…c for live preview - Changed iframe source URL from localhost to a Chromatic URL for better accessibility during development. - This update ensures that the iframe displays the latest version of the CafeUnitTest component in a live environment. This commit focuses on improving the development workflow by providing a reliable source for the iframe content.
- Deleted the yarn.lock file as it is autogenerated and should not be edited directly. - This change helps maintain a clean project structure by removing unnecessary files. This commit focuses on ensuring that the project does not include autogenerated files that can lead to confusion during development.
* update discord links * change cdp to buildonbase link
* New privacy policy banner * removing logs * fix link * fixes * ensure link doesn't wrap * update banner for all top level pages * update banner content * update banner text and update more pages with banner * adding to learn * add to more pages * updating more pages
ericbrown99
approved these changes
Jul 2, 2025
Open
|
The Connect Wallet on the learning exercise still opens the new base app wallet and not metamask: https://docs.base.org/learn/deployment-to-testnet/deployment-to-testnet-exercise Was it fixed with this PR? Is there anything I can do to connect my MetaMask wallet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56 | Closes #51
🔧 Issues Fixed
Issue #56: MetaMask connection not working - only Coinbase Wallet was available in learning exercises
Issue #51: Broken iframe story reference due to typo
"fiftteen"→"fifteen"✅ Changes Made
MetaMask Support
wallet: { display: 'modal' }<ConnectWallet>instead of<WalletDefault>Iframe Fix
erc-721-exercise.mdx:components-cafeunittest--fiftteen→components-cafeunittest--fifteenUI Improvements
📝 Files Modified
storybook/stories/components/CafeUnitTest/index.jsxdocs/learn/token-development/erc-721-token/erc-721-exercise.mdx🎯 Impact
Result: MetaMask connection fixed + iframe issues resolved + UI enhanced! 🚀