Cobalt and fixes - #14
Merged
Merged
Conversation
Collaborator
🟡 Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
montycheese
approved these changes
Jul 23, 2026
Collaborator
|
Review Error for montycheese @ 2026-07-23 00:48:13 UTC |
montycheese
added a commit
that referenced
this pull request
Aug 5, 2026
Nothing caught #14 dropping zeronet from /api/snapshots. The page looked right, every test passed, and the breakage only surfaced when zeronet nodes could not sync from a snapshot. Adds app/snapshots/networks.contract.test.ts, asserting the API surface rather than the rendered page: every expected network is served, hiding one from the UI is a `hiddenFromUi` flag rather than a deletion, each network carries the config the loader needs, and ids/buckets/env prefixes stay unique. Verified it has teeth by replaying #14's deletion — three assertions fail with messages naming the missing network. It also asserts each network's R2 env prefix appears in .env.example. Because loadSnapshots throws when any network fails, a network added without documented credentials 502s the whole endpoint, so this catches at PR time the config half of a failure that otherwise only shows up in production. Runs as its own `snapshots API contract` check so it can be required in branch protection and is legible in the PR list. NETWORK_CONFIGS is exported read-only for the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary