fix(vibenet): make 'Add to wallet' idempotent and clear - #21
Merged
Conversation
Hitting 'Add to wallet' for an already-added network fired wallet_addEthereumChain, which most wallets treat as a switch prompt; a dismissed prompt (EIP-1193 4001) was then surfaced as 'Wallet did not add the network: User rejected the request' — misleading, since it's already added. Now: read eth_chainId first and short-circuit with 'Already connected' when on vibenet; otherwise switch (EIP-3326) and only add on 4902 (unrecognized chain); treat 4001 as a neutral 'Request dismissed' rather than a failure. Adds getChainId / switchEthereumChain / isUserRejection / isUnrecognizedChain helpers to library/wallet.ts. typecheck/lint/build pass.
Collaborator
🟡 Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hitting Add to wallet for a network the wallet already has showed:
wallet_addEthereumChainon an already-added chain doesn't re-add it — most wallets treat it as a switch request and prompt to switch. Dismissing that prompt returns EIP-11934001, which the handler reported as an add-failure. Misleading: the network was already there.Fix (best-UX flow)
eth_chainIdfirst — if already on vibenet, show "Already connected to base vibenet." and don't prompt at all.wallet_switchEthereumChain, EIP-3326); only fall back to add (wallet_addEthereumChain) when the wallet reports the chain is unrecognized (4902).4001dismissal as a neutral "Request dismissed — no changes made." instead of a failure.Adds
getChainId,switchEthereumChain,isUserRejection,isUnrecognizedChainhelpers tolibrary/wallet.ts.Verification
<img>warnings, untouched by this change).