Collection notifications fix - #1176
Merged
Merged
Conversation
skyfallwastaken
pushed a commit
to skyfallwastaken/fizzy
that referenced
this pull request
Mar 7, 2026
codeberg and tangled let's go Co-authored-by: Neon <neon@saahild.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a couple supremely confusing things with the collection notification settings page. Before, we were simply hiding the text labels for the involvement button. Unfortunately, that completely reversed the meaning of the buttons:
🔔 Watch thisbecame🔔, which looks like you currently have notifications enabled (even though you don't).This PR changes things so that when an involvement button has
icon_only: true, the icon is flipped. I also ensured that theicon_onlyprop persists between turboframe reloads.