Skip to content

Mobile / Tweak bridge buttons#2611

Merged
adjogima merged 10 commits into
mainfrom
mobile/tweak-bridge-buttons
Feb 26, 2026
Merged

Mobile / Tweak bridge buttons#2611
adjogima merged 10 commits into
mainfrom
mobile/tweak-bridge-buttons

Conversation

@adjogima

@adjogima adjogima commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Add display-title (ie. button with icon + text) and display-as-primary-action (ie. more prominent style) button parameters.

Quick test on iOS (don't pay attention to the actual look of the colored buttons, I didn't want to fight with UIKit) 👇

Simulator.Screen.Recording.-.iPhone.17.-.2026-02-25.at.17.55.42.mov

@adjogima
adjogima requested a review from jayohms February 25, 2026 16:58
Comment thread app/javascript/initializers/bridge/bridge_element.js Outdated
Comment thread app/javascript/initializers/bridge/bridge_element.js Outdated
Comment thread app/javascript/initializers/bridge/bridge_element.js Outdated
Copilot AI review requested due to automatic review settings February 26, 2026 10:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the mobile bridge button functionality by adding two new parameters: show-label (displays button text alongside icons) and main-action (applies more prominent styling). The changes update multiple button instances across the application to use these new features, making key actions like "Add card" and "Mark done" more prominent and accessible on mobile devices.

Changes:

  • Added displayTitle and isMainAction properties to the bridge button configuration
  • Updated "Add card", "Add board", and "Mark done" buttons to display labels and be styled as main actions
  • Standardized button titles across the application (e.g., "Add a card" → "Add card")

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
app/views/events/index/_add_card_button.html.erb Updated "Add card" button with main action styling and visible title
app/views/events/index/_add_board_button.html.erb Updated "Add board" button with visible title
app/views/columns/show/_add_card_button.html.erb Updated "Add card" button with main action styling and visible title
app/views/cards/container/_closure_buttons.html.erb Updated "Mark done" button with main action styling and visible title
app/javascript/initializers/bridge/bridge_element.js Added displayTitle and isMainAction properties to bridge button configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/views/events/index/_add_card_button.html.erb Outdated
Comment thread app/views/columns/show/_add_card_button.html.erb
Comment thread app/views/events/index/_add_board_button.html.erb
Comment thread app/views/cards/container/_closure_buttons.html.erb
Comment thread app/javascript/initializers/bridge/bridge_element.js Outdated
Copilot AI review requested due to automatic review settings February 26, 2026 10:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/views/events/index/_add_card_button.html.erb Outdated
Comment thread app/views/columns/show/_add_card_button.html.erb Outdated
Comment thread app/views/cards/container/_closure_buttons.html.erb Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 26, 2026 11:14
adjogima and others added 2 commits February 26, 2026 12:14
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/views/events/index/_add_board_button.html.erb
Comment thread app/views/columns/show/_add_card_button.html.erb
Comment thread app/views/cards/container/_closure_buttons.html.erb
Comment thread app/views/events/index/_add_card_button.html.erb
@adjogima
adjogima merged commit 1505ed7 into main Feb 26, 2026
12 checks passed
@adjogima
adjogima deleted the mobile/tweak-bridge-buttons branch February 26, 2026 12:23
sarrietav-dev added a commit to sarrietav-dev/fizzy that referenced this pull request Mar 18, 2026
…ty-Q98x2

Merge pull request basecamp#2611 from basecamp/mobile/tweak-bridge-buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants