Allow overriding default browser via $BROWSER - #4340
Closed
thejesus567 wants to merge 2 commits into
Closed
Conversation
Member
|
Appreciate the idea and the option, but I actually think this is more confusing for most users, as browsers already natively support the xdg-settings approach. They usually offer you "Make this your default browser" when you open them, and if you accept, they trigger that xdg-settings flow. So I prefer to stick to just one option here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When I first started using Omarchy, I had some issues trying to change the default browser.
Currently, the only documented way to do this is by running:
xdg-settings set default-web-browser(as discussed here: #985)
This simple PR adds a more straightforward option: allowing users to set the
$BROWSERenvironment variable in the default config file.What changed
omarchy-launch-browsernow respects$BROWSERif it is set$BROWSERis not set, it falls back toxdg-settings(current behavior)Why
Setting an environment variable is simpler, more explicit, and consistent with common Linux conventions. It also avoids having to run
xdg-settingsmanually just to override the browser.