ghui autoreloads oma theme#5589
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to make ghui follow Omarchy theme switches by (1) installing a default ghui config that uses the system theme and (2) triggering a ghui reload as part of omarchy-theme-set.
Changes:
- Add a migration to seed
~/.config/ghui/config.jsonwith Omarchy’s defaultghuiconfiguration. - Add
omarchy-restart-ghuiand invoke it duringomarchy-theme-setto reloadghuiwhen themes change. - Ensure
omarchy-remove-preinstallsalso removes theghuinpx wrapper stub.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| migrations/1777978416.sh | Seeds a default ghui config file under ~/.config/ghui/. |
| config/ghui/config.json | Adds default ghui settings to use the system theme and enable auto-reload. |
| bin/omarchy-theme-set | Hooks ghui reload into Omarchy’s theme application flow. |
| bin/omarchy-restart-ghui | Introduces a restart/reload helper for ghui (signal-based). |
| bin/omarchy-remove-preinstalls | Removes the ghui npx wrapper stub during preinstall removal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,6 @@ | |||
| echo "Configure ghui with system themeing" | |||
ilyaZar
force-pushed
the
feat-omarchy-ghui-theme-reload
branch
from
3ce050b to
aefaf06
Compare
|
Hmm. This isn't working when I try it. ghui crashes when it gets the signal. |
|
yes have you checked out my PR on the other side at ghui ahnd installed from the branch ? |
|
Ahh. No, I just tried with the current released version! |
|
yeah sorry, my bad... I should've been clearer in my initial post it makes more sense to wait if the ghui feature lands before testing the omarchy installation path actually |
ilyaZar
force-pushed
the
feat-omarchy-ghui-theme-reload
branch
from
aefaf06 to
00d07c0
Compare
ilyaZar
force-pushed
the
feat-omarchy-ghui-theme-reload
branch
from
00d07c0 to
e652c02
Compare
ilyaZar
force-pushed
the
feat-omarchy-ghui-theme-reload
branch
from
e652c02 to
d04e1ea
Compare
|
@dhh so my kitlangton/ghui#28 got merged ! the auto theme feature should be testable now , oma's npx should pick up the new |
|
It's not working right here. Here's me switching to tokyo night in alacritty: 
|
Hi all,
thanks a lot for oma , I enjoy it a lot. also thanks for 3.7.0/1 great updates
would be cool if
ghui, now that its part of oma, would get the cool theme switching whenever the main omarchy theme switches as wellthis PR does that following the way
opencodeimplements a similar feature in the older #4566 , #4582 PRsattention: so
ghuidoes yet not receive thesigusrsignal on the other side, but I made a matching PR there to add this feature kitlangton/ghui#28would be really nice to have the auto theme switch at some future point !