Skip to content

typo themeing -> theming#5593

Merged
dhh merged 1 commit intobasecamp:devfrom
ilyaZar:fix-themeing-typo
May 5, 2026
Merged

typo themeing -> theming#5593
dhh merged 1 commit intobasecamp:devfrom
ilyaZar:fix-themeing-typo

Conversation

@ilyaZar
Copy link
Copy Markdown
Contributor

@ilyaZar ilyaZar commented May 5, 2026

I noticed copilot complaining in #5589 about the word "themeing" so I checked its existence

word counter in omarchy

themeing: twice vs theming : once

maybe innocous as printed during migrations only but agents tend to pick up words they find in code and reproduce that pattern

though only lightly user facing , I'd change themeing -> theming

Copilot AI review requested due to automatic review settings May 5, 2026 14:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a user-facing typo in migration messages by changing “themeing” to “theming”, reducing the chance that tooling/agents repeat the misspelling elsewhere.

Changes:

  • Update migration echo text in two migration scripts to use “theming” consistently.
  • Remove the last occurrences of the misspelling “themeing” from the repository.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
migrations/1769510847.sh Fixes typo in migration status message (“themeing” → “theming”).
migrations/1767478687.sh Fixes typo in migration status message (“themeing” → “theming”).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dhh dhh merged commit 4ac9c99 into basecamp:dev May 5, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants