Drop app bindings when their launcher entry is removed - #6489
Open
husamemadH wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Makes application keybindings follow launcher availability and reloads Hyprland after launcher changes.
Changes:
- Adds launcher-entry checks to application bindings.
- Reloads Hyprland after web app and TUI installation/removal.
- Adds binding and web app removal tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
default/hypr/helpers.lua |
Filters bindings by launcher availability. |
default/hypr/bindings/applications.lua |
Associates bindings with desktop entries. |
bin/omarchy-webapp-install |
Reloads Hyprland after installation. |
bin/omarchy-webapp-remove |
Reloads Hyprland after removal. |
bin/omarchy-tui-install |
Reloads Hyprland after installation. |
bin/omarchy-tui-remove |
Reloads Hyprland after removal. |
test/shell.d/hyprland-default-config-test.sh |
Tests launcher-dependent bindings. |
test/shell.d/webapp-remove-test.sh |
Tests removal and configuration reload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+73
to
+75
| function o.launcher_entry_exists(name) | ||
| return file_exists((os.getenv("HOME") or "") .. "/.local/share/applications/" .. name .. ".desktop") | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing a web app from the launcher left its keybinding working, so
SUPER + SHIFT + Ystill opened YouTube after removal. Bindings now declare the launcher entry they belong to and are skipped when it is gone, and the install/remove commands reload Hyprland so it takes effect immediately.Motivation
Fixes #6468.