fix(commons): check Process.running before triggering hyprctl & fc-match in Style.qml - #6506
fix(commons): check Process.running before triggering hyprctl & fc-match in Style.qml#6506shrijit37 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Attempts to prevent overlapping hyprctl and fc-match process triggers in shared shell styling.
Changes:
- Adds running-state guards before starting style refresh processes.
- Adds the same guard for font-family resolution.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Suppressed comments (1)
shell/Commons/Style.qml:464
- A fontconfig change that occurs while
fc-matchis running is still discarded because this branch does nothing in that case. The existing run can resolve the pre-change configuration and no later event is guaranteed, leavingresolvedFontFamilystale. Record a pending resolution while busy and rerun it fromfcMatchProc.onExited.
if (!fcMatchProc.running) fcMatchProc.running = true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (!hyprctlProc.running) hyprctlProc.running = true | ||
| if (!gapsOutProc.running) gapsOutProc.running = true |
bbabb41 to
c764596
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
default/hypr/apps/browser.lua:10
- This deletion is unrelated to the stated process-refresh fix and changes user-visible behavior: browser screen-sharing notification windows will now remain on the active workspace instead of being hidden. Restore the rule unless this behavior change is intentionally included and documented in the PR scope.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
| -- Video apps: remove chromium browser tag so they don't get opacity applied. | ||
| o.window("(^.+-youtube\\.com__.*$|^.+-app\\.zoom\\.us__wc_home.*$)", { tag = "-chromium-based-browser" }) | ||
| o.window("(^.+-youtube\\.com__.*$|^.+-app\\.zoom\\.us__wc_home.*$)", { tag = "-default-opacity" }) | ||
| o.window("(^.+\-youtube\\.com__.*$|^.+\-app\\.zoom\\.us__wc_home.*$)", { tag = "-default-opacity" }) |
…tyle.qml - Queue pending refresh and font-family resolution requests when processes are in-flight. - Rerun pending requests on process completion so rapid theme/config changes are not dropped.
d8dc07a to
cb18032
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary
Setting
Process.running = truewhile a QuickshellProcesscomponent is already running is a no-op in Quickshell, dropping the refresh request.Fix
Check
if (!proc.running)before assigningrunning = trueinrefresh()andresolveFontFamily().