fix(shell): switch route when toggle requested for open menu & prevent XF86PowerOff key repeat

[shrijit37]

Summary

1. Route Switching on Toggle: When omarchy-menu toggle system is invoked while the menu is already open at a different route (e.g. root or apps), shell.qml's toggle() used to immediately close the menu instead of navigating to the requested route (system).
2. Keyboard Power Key Repeat: Holding down the physical keyboard power button past 400ms causes Hyprland to auto-repeat XF86PowerOff, rapidly toggling the menu open and closed 40 times per second.

Fix

• Update shell.qml's toggle() to check if the menu is active at a different sub-route, calling summon() to switch routes rather than closing.
• Add repeat = false to the XF86PowerOff binding in utilities.lua to suppress key repeat.

Review follow-up

Initial review noted resolveRoute() expanded aliases but didn't follow link entries, so toggling a link route (e.g. install.style → style.install) re-summoned instead of closing. Also missing regression coverage.

• Added Menu.canonicalRoute() mirroring exactly what an open will display: aliases → link targets → root fallback for unknown ids. shell.qml toggle() now compares canonical routes (with a link-follow fallback for third-party menu panels).
• XF86PowerOff binding test now asserts locked = true and repeating = false (test/shell.d/hyprland-default-config-test.sh).

Round 2 (post-re-review)

• The route comparison was only testable through source-token regexes. The canonicalization and the toggle decision are now shared model functions (MenuModel.canonicalRoute() / MenuModel.shouldSummonForRoute()), and Menu.qml + shell.qml delegate to them.
• Behavioral regression coverage in test/shell.d/menu-test.sh against a real menu heap: alias and link canonicalization; toggling the already-active route (including via alias or link) hides; a different route summons; an active dmenu request is never clobbered; third-party panels with only resolveRoute/items get the same link-follow behavior.

Testing: menu-test.sh 98 ok · app-search-test.sh green · hyprland-default-config-test.sh green · full ./test/shell green against the same single pre-existing environment baseline.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[Copilot]

Pull request overview

Fixes menu route toggling and power-key repetition, alongside several shell reliability changes.

Changes:

• Adds route-aware menu toggling and power-key repeat handling.
• Coalesces concurrent scans and guard evaluations.
• Adjusts notification icons, provider errors, bar injection, and style refreshes.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
shell/shell.qml	Switches routes when toggling an open menu.
shell/services/AppLibrary.qml	Changes scan shells and queues icon rescans.
shell/plugins/notifications/components/NotificationCard.qml	Resolves file-backed notification icons.
shell/plugins/model-usage/providers/Claude.qml	Suppresses expected missing-file errors.
shell/plugins/menu/Menu.qml	Queues concurrent guard evaluations.
shell/plugins/bar/Bar.qml	Guards dynamic property injection.
shell/Commons/Style.qml	Prevents restarting active processes.
default/hypr/bindings/utilities.lua	Attempts to disable power-key repetition.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Suppressed comments (2)

shell/shell.qml:524

• resolveRoute() expands aliases but does not follow link entries; Menu.openRoute() follows those separately (Menu.qml:865-868). As a result, opening install.style sets activeMenu to style.install, and toggling install.style again sees two different IDs and reopens the menu instead of closing it. Canonicalize link targets before comparing routes.

          var resolvedTarget = loader.item.resolveRoute(targetRoute)
          var resolvedActive = loader.item.resolveRoute(loader.item.activeMenu)
          if (resolvedTarget && resolvedActive && resolvedTarget !== resolvedActive) {
            return summon(id, payloadJson)

shell/shell.qml:512

• The new route-switching branch has no regression coverage: existing shell tests exercise summon/hide, while the acceptance menu test only summons root. Add a test that opens one route, toggles a different route and confirms the menu remains open on the requested route, then toggles that route again and confirms it closes; include a link route to cover canonicalization.

    if (!isPluginOpen(id)) return summon(id, payloadJson)

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (3)

shell/shell.qml:521

• resolveRoute() only normalizes aliases; it does not return the route that openRoute() will actually display. For example, install.style redirects to style.install, and an unknown route falls back to root. If that effective route is already active, this comparison still calls summon() and resets the menu instead of toggling it closed. Canonicalize redirects and missing items before comparing with activeMenu.

          var resolvedTarget = loader.item.resolveRoute(targetRoute)
          var resolvedActive = loader.item.resolveRoute(loader.item.activeMenu)
          if (resolvedTarget && resolvedActive && resolvedTarget !== resolvedActive) {

shell/shell.qml:523

• This new toggle branch has no regression coverage, although test/acceptance.d/menu-test.sh already exercises menu routing. Add cases that open one route and toggle to another, then toggle the same effective route closed (including an alias/redirect such as install.style → style.install) so route canonicalization and close behavior are both verified.

          if (resolvedTarget && resolvedActive && resolvedTarget !== resolvedActive) {
            return summon(id, payloadJson)

default/hypr/bindings/utilities.lua:8

• The power-key regression is not covered by the existing Hyprland binding test, which currently discards binding options. Extend test/shell.d/hyprland-default-config-test.sh to record the XF86PowerOff options and assert that locked remains true and repeating is false; otherwise a future binding edit can silently restore the rapid menu toggling.

o.bind("XF86PowerOff", "Power menu", "omarchy-menu toggle system", { locked = true, repeating = false })

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

shell/shell.qml:512

• The new stateful toggle behavior is not covered by the shell tests: the existing acceptance test only summons system directly, so it would still pass if this branch always hid the menu. Add a focused test that opens root, toggles system, and verifies the menu remains open with the system route visible; also cover toggling the already-active route to close it.

    if (!isPluginOpen(id)) return summon(id, payloadJson)

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (1)

test/shell.d/app-search-test.sh:150

• These assertions only match source-code tokens, so they can pass even if canonicalRoute() returns the wrong route or toggle() still hides/summons incorrectly. The PR's core route-switching behavior therefore has no executable regression coverage. Please exercise toggle() with a loaded fake/menu item and assert different-route summon, same-route hide, alias/link handling, and dmenu cancellation (for example in a QML shell fixture).

  /function toggle\(pluginId, payloadJson\) \{[\s\S]*?canonicalRoute[\s\S]*?resolvedTarget[\s\S]*?resolvedActive[\s\S]*?resolvedTarget !== resolvedActive[\s\S]*?return summon\(id, payloadJson\)/.test(shellQml),
  'shell toggle compares canonical routes so summoning the already-active route closes the menu instead'
)
assert(
  /function toggle[\s\S]*?kind === "link"[\s\S]*?ent\.target[\s\S]*?\}[\s\S]*?return hide/.test(shellQml),
  'shell toggle falls back to menu link resolution when a panel lacks canonicalRoute'

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Suppressed comments (1)

shell/plugins/menu/MenuModel.js:176

• “purecallers” is missing a space; use “pure callers” so the new API comment reads correctly.

// runtime alias resolver; purecallers without aliases omit it.