Enable DNS-over-TLS for custom DNS providers - #6513
Open
KazeTachinuu wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omarchy dns Customsilently disables DNS-over-TLS.Each provider branch overwrites
/etc/systemd/resolved.confwholesale.CloudflareandGooglewriteDNSOverTLS=opportunistic,DHCPwritesDNSOverTLS=nodeliberately, andCustomwrites neither, so resolved falls back to its documented default ofno.Because it is an overwrite rather than an edit, selecting
CustomafterCloudflareorGooglealso drops an already-encrypted resolver back to plaintext, with nothing in the output to say so.Observed on a machine configured with
omarchy dns Custompointing at Quad9:Quad9 does support DoT, so this is a silent downgrade rather than an unavoidable fallback:
opportunisticrather thanyeskeeps the command's own192.168.1.1example working: a LAN resolver that does not speak DoT still resolves, one that does gets upgraded, andCustomstays consistent with the other branches instead of introducing a third behaviour.The omission dates to 27497b1, which added all four branches and gave three of them the line.
bin/omarchy-dnsis the only file in the repo that writes DNS resolution settings, and the shippedresolved.conf.ddrop-ins do not touch DoT.Verified:
bash -n bin/omarchy-dnsclean,./test/clipasses, and the patched heredoc renders the expected[Resolve]block for both single and comma-separated server input. The privileged end-to-end run (omarchy dns Customas root, thenresolvectl status) has not been executed on this machine.