install: remove stale versioned dylibs on upgrade - #63
Merged
Conversation
The clean-install step removed `libbaseRT.dylib` but not `libbaseRT.<version>.dylib`. That was harmless while the macOS bundle shipped one flat library — but 0.2.4 ships a VERSIONED library plus two symlinks (libbaseRT.0.2.4.dylib <- libbaseRT.0.dylib <- libbaseRT.dylib), and the bare name matches only the last of those. So every upgrade from 0.2.4 on leaves the previous release's real library behind: a full-size orphan nothing points at, accumulating one per upgrade. Observed on a live install carrying both libbaseRT.0.2.0.dylib and libbaseRT.0.2.4.dylib. Benign today because the symlinks resolve correctly, but it is a loaded gun for any future change to the install name. `libbaseRT*.dylib` now, matching the treatment `libbaseRT.so*` already had. Verified both directions against a dirty install seeded with 0.2.0 and 0.2.3 libraries: the old script leaves all three stacked up, the fixed one keeps exactly libbaseRT.0.2.4.dylib and its two symlinks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clean-install step removes
libbaseRT.dylibbut notlibbaseRT.<version>.dylib.That was harmless while the macOS bundle shipped one flat library. 0.2.4 changed that — it now ships a versioned library plus two symlinks:
and the bare name matches only the last of those. So every upgrade from 0.2.4 on leaves the previous release's real library behind: a full-size orphan nothing points at, one per upgrade. Seen on a live install carrying both
libbaseRT.0.2.0.dylibandlibbaseRT.0.2.4.dylib.Benign today, since the symlinks resolve correctly. It is a loaded gun for any future change to the install name.
libbaseRT*.dylibnow — the same treatmentlibbaseRT.so*already had.Verified both directions against a dirty install seeded with 0.2.0 and 0.2.3 libraries:
libbaseRT.0.2.0+libbaseRT.0.2.3+libbaseRT.0.2.4all left behindlibbaseRT.0.2.4.dyliband its two symlinks