Skip to content

Harden embedded secret redaction - #215

Merged
codeforester merged 1 commit into
mainfrom
security/211-20260818-redaction-fallback-misses-secrets-embedded-in-query-strings
Aug 18, 2026
Merged

Harden embedded secret redaction#215
codeforester merged 1 commit into
mainfrom
security/211-20260818-redaction-fallback-misses-secrets-embedded-in-query-strings

Conversation

@codeforester

Copy link
Copy Markdown
Contributor

Summary

  • fix generic inline redaction so every recognized key=value segment is scanned
  • redact recognized secrets in header-style key: value segments without hiding adjacent non-secret values
  • add regression coverage for query strings, comma-separated values, and HTTP headers
  • document the expanded security control and include the fix in the unreleased changelog

Closes #211.

Validation

  • UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra dev --extra quality pytest
  • UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra quality ruff format --check lib/python/base_cli/redaction.py tests/test_redaction_security.py
  • UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra quality ruff check lib/python/base_cli/redaction.py tests/test_redaction_security.py
  • UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra quality mypy lib/python/base_cli/redaction.py
  • ./tests/validate.sh

@codeforester
codeforester merged commit c4b0c31 into main Aug 18, 2026
128 of 130 checks passed
@codeforester
codeforester deleted the security/211-20260818-redaction-fallback-misses-secrets-embedded-in-query-strings branch August 18, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redaction fallback misses secrets embedded in query strings, comma-separated lists, and header-style values

1 participant