Conversation
Contributor
There was a problem hiding this comment.
IMO more informative to use assertTrue()
Contributor
Author
There was a problem hiding this comment.
I guess that's true, but it leads to slightly different behavior though - if an assertTrue() fails, it will just say "assertion failed" Failing an assertEquals throws a comparison failure with large nice message.
alexmoore
added a commit
that referenced
this pull request
Jan 6, 2016
Add Create Tables Tests for Time Series.
|
@alexmoore Were you looking for more review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test to create TS tables through the SQL interface, refactor some tests.