Links on documents with keys with slashes were failing to save#64
Closed
chrisumbel wants to merge 1 commit intobasho:masterfrom
Closed
Links on documents with keys with slashes were failing to save#64chrisumbel wants to merge 1 commit intobasho:masterfrom
chrisumbel wants to merge 1 commit intobasho:masterfrom
Conversation
russelldb
added a commit
that referenced
this pull request
Oct 11, 2011
Contributor
|
I was just doing the tagging for 1.0, this is in, many thanks. |
Contributor
Author
|
awesome, thanks. keep up the good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getBasePathFromHttpMethod was using URI.getPath which decodes the url before returning it. if the document's key had a forward slash this would cause only a portion of the key to be removed from the end of the path before determining it's base. that in turn caused the bucket name of the original document to be left on the base i.e.
/riak/owning_doc_bucket/linked_doc_bucket/key
getRawPath does not decode the path so the link is determined correctly i.e.
/riak/linked_doc_bucket/key