Skip to content

CLIENTS-115: Use pyenv for multiple Python versions and tox to test them#392

Merged
borshop merged 2 commits intomasterfrom
feature/bch/tox
Jan 22, 2015
Merged

CLIENTS-115: Use pyenv for multiple Python versions and tox to test them#392
borshop merged 2 commits intomasterfrom
feature/bch/tox

Conversation

@hazen
Copy link
Copy Markdown

@hazen hazen commented Dec 31, 2014

Traditionally we've targeted only Python 2.7.x as our supported build version. In fact the native Ubuntu 12.04 LTS version 2.7.3 is the only one tested on buildbot. Now we'll use pyenv to virtualize 4 versions and actually test all of them both with and without security:

  • 2.6.9
  • 2.7.9
  • 3.3.6
  • 3.4.2

The real downside is, naturally, that the tests will take 4x longer, but this way we can catch changes which break one platform or another.

NOTE: Because of the older version of OpenSSL installed on the builder we need to allow older TLS versions to be supported in Riak since the Python 3 versions use the builtin ssl library instead of PyOpenSSL.

@christophermancini
Copy link
Copy Markdown

So, I ran into a problem with hard links and virtual box file sharing. I had to place the following at the beginning of the setup.py in order to complete the tox run.

if os.environ.get('USER','') == 'vagrant':
    del os.link

The code looks good and I was able to run the tests against all 4 target versions of python. I would consider adding the above to the setup.py to handle the edge case I ran into using a Virtual Box vm as my test server.

@christophermancini
Copy link
Copy Markdown

👍f9acd6e

@hazen
Copy link
Copy Markdown
Author

hazen commented Jan 20, 2015

@borshop merge

@christophermancini
Copy link
Copy Markdown

👍 f9acd6e

@hazen
Copy link
Copy Markdown
Author

hazen commented Jan 20, 2015

@borshop merge

borshop added a commit that referenced this pull request Jan 20, 2015
CLIENTS-115: Use pyenv for multiple Python versions and tox to test them

Reviewed-by: christophermancini
@hazen hazen force-pushed the feature/bch/tox branch 2 times, most recently from fed3f35 to dd953b3 Compare January 20, 2015 22:20
@hazen
Copy link
Copy Markdown
Author

hazen commented Jan 20, 2015

@christophermancini I had to wack the builder a couple of times, but looks like this should work.

@christophermancini
Copy link
Copy Markdown

👍 ede2838

borshop added a commit that referenced this pull request Jan 21, 2015
CLIENTS-115: Use pyenv for multiple Python versions and tox to test them

Reviewed-by: christophermancini
borshop added a commit that referenced this pull request Jan 21, 2015
CLIENTS-115: Use pyenv for multiple Python versions and tox to test them

Reviewed-by: christophermancini
borshop added a commit that referenced this pull request Jan 21, 2015
CLIENTS-115: Use pyenv for multiple Python versions and tox to test them

Reviewed-by: christophermancini
@hazen
Copy link
Copy Markdown
Author

hazen commented Jan 21, 2015

@borshop merge

@borshop borshop merged commit ede2838 into master Jan 22, 2015
@hazen hazen deleted the feature/bch/tox branch May 6, 2016 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants