CLIENTS-115: Use pyenv for multiple Python versions and tox to test them#392
Merged
CLIENTS-115: Use pyenv for multiple Python versions and tox to test them#392
Conversation
|
So, I ran into a problem with hard links and virtual box file sharing. I had to place the following at the beginning of the setup.py in order to complete the tox run. The code looks good and I was able to run the tests against all 4 target versions of python. I would consider adding the above to the setup.py to handle the edge case I ran into using a Virtual Box vm as my test server. |
|
👍f9acd6e |
Author
|
@borshop merge |
|
👍 f9acd6e |
Author
|
@borshop merge |
borshop
added a commit
that referenced
this pull request
Jan 20, 2015
CLIENTS-115: Use pyenv for multiple Python versions and tox to test them Reviewed-by: christophermancini
fed3f35 to
dd953b3
Compare
dd953b3 to
ede2838
Compare
Author
|
@christophermancini I had to wack the builder a couple of times, but looks like this should work. |
|
👍 ede2838 |
borshop
added a commit
that referenced
this pull request
Jan 21, 2015
CLIENTS-115: Use pyenv for multiple Python versions and tox to test them Reviewed-by: christophermancini
borshop
added a commit
that referenced
this pull request
Jan 21, 2015
CLIENTS-115: Use pyenv for multiple Python versions and tox to test them Reviewed-by: christophermancini
borshop
added a commit
that referenced
this pull request
Jan 21, 2015
CLIENTS-115: Use pyenv for multiple Python versions and tox to test them Reviewed-by: christophermancini
Author
|
@borshop merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traditionally we've targeted only Python 2.7.x as our supported build version. In fact the native Ubuntu 12.04 LTS version 2.7.3 is the only one tested on buildbot. Now we'll use
pyenvto virtualize 4 versions and actually test all of them both with and without security:The real downside is, naturally, that the tests will take 4x longer, but this way we can catch changes which break one platform or another.
NOTE: Because of the older version of OpenSSL installed on the builder we need to allow older TLS versions to be supported in Riak since the Python 3 versions use the builtin
ssllibrary instead ofPyOpenSSL.