HyperLogLog support #492
Merged
HyperLogLog support #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return [bytes_to_str(string[:]) for string in set_value] | ||
|
|
||
| def decode_hll_value(self, hll_value): | ||
| return int(hll_value) |
Contributor
Author
There was a problem hiding this comment.
Note: in Python 2, int() thankfully does the right thing if hll_value requires a long internally.
| def check_op_output(self, op): | ||
| self.assertIn('adds', op) | ||
| self.assertItemsEqual(op['adds'], ['bar', 'foo']) | ||
| self.assertIn('removes', op) |
Contributor
There was a problem hiding this comment.
Did you mean to remove these lines from the Set Unit tests?
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #491 (CLIENTS-979)