Smart re-try for operations #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
changed the title
|
Code looks good and tests pass. Do we have tests that confirm connections are closed? |
Contributor
Author
Not sure why we would need that? For this change the only way to test it is to use haproxy with really short timeouts https://gist.github.com/lukebakken/81c0609c274b083272f182443a6267f5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an operation immediately receives an error indicating a closed socket (common with Amazon ELB), re-try it at least once no matter the global retry settings. This will also be done for streaming operations that are normally not retried at all, since it is safe to re-try in this specific case.
Fixes #503 (CLIENTS-1049)