Skip to content

support multi-exist check by making mutli operation generic#291

Closed
grosser wants to merge 1 commit into
basho:masterfrom
grosser:grosser/sh
Closed

support multi-exist check by making mutli operation generic#291
grosser wants to merge 1 commit into
basho:masterfrom
grosser:grosser/sh

Conversation

@grosser

@grosser grosser commented Dec 2, 2016

Copy link
Copy Markdown
Contributor
  • Unit tests for your change
  • Integration tests (if applicable)

@lukebakken

/cc @gabetax

@lukebakken lukebakken added this to the riak-ruby-client-2.5.0 milestone Dec 2, 2016
@lukebakken lukebakken self-assigned this Dec 2, 2016
@lukebakken

Copy link
Copy Markdown
Contributor

This looks pretty cool. I recommend keeping pre-existing names (multiget_threads) and methods (get_all) for backwards compatibility. You can use aliases to introduce new names with notices / docs about deprecation.

@grosser grosser force-pushed the grosser/sh branch 4 times, most recently from ed14dbd to fc82fa9 Compare December 9, 2016 04:56
@grosser

grosser commented Dec 10, 2016

Copy link
Copy Markdown
Contributor Author

all green now!

@lukebakken lukebakken modified the milestones: riak-ruby-client-2.5.0, riak-ruby-client-2.5.1 Dec 12, 2016
@lukebakken

lukebakken commented Dec 12, 2016

Copy link
Copy Markdown
Contributor

Included in #298 (CLIENTS-907), thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants