Riak Ruby Client 2.6.0#298
Conversation
|
👍 |
|
I'll make a followup PR to add coverage to all files next ... not sure when you are planing to merge 2.6 |
|
Today or tomorrow. No hurry on that follow-up PR. |
|
1.9 builds are failing because then |
|
Yeah, let's put that back. Some of our supported operating systems ship with 1.9.3 so .... |
lukebakken
force-pushed
the
features/lrb/riak-client-2.6.0
branch
2 times, most recently
from
9590aea to
44ade91
Compare
actionable code coverage + do not allow new uncovered code test should include unit-test more coverage - fix finished saying true when asking before performing - simplify finished logic - do not allow access to inconsistent finished accessor Add target to just run timeseries tests simplify fetch list validation logic and move all validations into initialize fix unit tests with @grosser's help make lint happy
lukebakken
force-pushed
the
features/lrb/riak-client-2.6.0
branch
from
44ade91 to
c74cc50
Compare
|
I was wondering why the multi stuff got moved into integration even though they do not require a running riak instance ... |
|
@grosser I saw a new client being instantiated and figured that it connected to Riak. I forgot that the Ruby client works differently than the other client libraries I work on as well. Any insight into the jruby errors? https://travis-ci.org/basho/riak-ruby-client/jobs/183472697 I can return to this PR once other, higher-priority work is done. Thank you for all of the time you have spent on these contributions. |
also removing thread_count check since it is impossible to reach this code because the client already checks it
mark mystery jruby error as pending ... it works fine without expect
2 participants
Includes #291