mark mystery jruby error as pending ... it works fine without expect#300
Merged
lukebakken merged 1 commit intoDec 13, 2016
Merged
Conversation
Contributor
Author
|
coverage seems to be also failing on jruby ... I'll deactivate if this is not green |
Merged
Contributor
Author
|
... ok this is crazy ... somehow the class gets poisoned by these expects ... I'll rewrite the test to not use expects ... |
also removing thread_count check since it is impossible to reach this code because the client already checks it
grosser
force-pushed
the
grosser/jrub
branch
from
2a44ec4 to
84ecf47
Compare
Contributor
Author
|
ok, hope all is good now :D |
lukebakken
reviewed
Dec 13, 2016
| self.thread_count = client.multi_threads | ||
| unless thread_count.is_a?(Integer) && thread_count > 0 | ||
| raise ArgumentError, t("invalid_multiget_thread_count") # TODO: should be invalid_multi_thread_count | ||
| end |
Contributor
There was a problem hiding this comment.
Sorry if it's obvious, why was this removed? I'm multitasking about 10 different things today.
Contributor
Author
There was a problem hiding this comment.
this code is unreachable/unestable since the only way of setting the multi_threads is client.multi_threads = which already guards against the value being invalid
Contributor
Author
|
only failure is https://travis-ci.org/basho/riak-ruby-client/jobs/183668812 ... but that looks random ... can you merge or restart this one so it gets green ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lukebakken
tried to reproduce it with a simpler setup to open a rspec/jruby issue but was unable,
something really specific about us multithreading and locking ... propably not worth the effort ...