Conversation
ghost
assigned
|
YES! It works as advertised, at least on my OSX. We need to figure out how to write a test for this, and try it on other machines. But it certainly killed what it needed to kill for me. |
|
Nice, going to test this today. But my first review comment is about the commit msg. Mind doing it in subject + body style (http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html). I know it's a bit of a contrived thing but various git tools seem to play better with commit msgs that follow that style. |
|
Why is the Monitor class under a different path than the other custom Java code? I.e. |
priv/build-jar.sh
Outdated
There was a problem hiding this comment.
The copying of this script should be in the grab-solr.sh script. This script is solely for building the yokozuna.jar. The grab-solr.sh is what builds the priv/solr directory.
|
Nice to see some git commit caremadness. My "favorite" is when people write things like "Checked in code changes." I'll look at that website, @rzezeski . So I initially put all the Java in the same jar, but it needs to be in a different place for Jetty, per my discussions with @coderoshi . It would be cleaner to have a single, duplicated jar, I guess, if that does not confuse Java. One is for Jetty and one for Solr (as I understand it.) |
|
We seem to have 2 methods of distribution: git build and binary download. We would not need the copy if I could have updated the Amazon tarball. I'm happy with killing the patch file, if you still think it's a good idea. |
Not sure I completely follow. Everything is built on top of the custom binary build. The |
riak_test/yz_monitor_solr.erl
Outdated
There was a problem hiding this comment.
Line comments start with double %.
|
Would like to have @jaredmorrow give a look at |
|
|
|
@jaredmorrow thx for the quick turn around. That's a good point about the other scripts. They are used during the actual building of Yokozuna so once we start migrating into master I suppose it will be important to update those if we want them to build w/o requiring installing bash? Not sure how much I rely on bash-only behavior or non-standard arguments to various commands. These build-time issues can be dealt with once that integration starts happening (hopefully in July). |
|
All of my builders have bash installed. So if they are only build time, I think we are fine. |
Jetty will launch a thread to periodically make sure YZ is still running; if not kill itself
* Fix compile path for `java_monitor` code. * Use repeating task at fixed rate (`readyForSuicide` was only running once). * Need to use static class in static context. * Add some additional output in test.
|
Hey Brett, I think you re-ran the verify script without blowing away your verify directory first. You need to do this when you change files involving the Had to make a few changes to get it to work but it passes for me now. |
|
Bummer. I was hoping to have tested the right thing. Guess I was a bit too hasty. I need to nuke solr to get that part to rebuild properly, right? I wonder if we should include that in the "make clean" target? |
|
Not just the solr dir. The Not sure we want to delete solr during clean. That will cause the tar to be downloaded (although perhaps that should be changed, only download if the md5 doesn't match). Perhaps a dist-clean or something. Or add a solr-clean and clean-all? |
5 participants
This PR closes Issue #124