hide searchbar if user is not authenticated#73
Merged
Conversation
saemideluxe
reviewed
Aug 31, 2021
bread/layout/skeleton.py
Outdated
| searchbar=hg.F(lambda c: c.get("SEARCHBAR", "")), | ||
| searchbar=hg.If( | ||
| hg.C("request.user.is_authenticated"), | ||
| hg.F(lambda c: c.get("SEARCHBAR", "")), |
Member
There was a problem hiding this comment.
I think hg.C("SEARCHBAR") would work the same and be a bit shorter.
saemideluxe
reviewed
Aug 31, 2021
bread/layout/skeleton.py
Outdated
| searchbar=hg.F(lambda c: c.get("SEARCHBAR", "")), | ||
| searchbar=hg.If( | ||
| hg.C("request.user.is_authenticated"), | ||
| hg.C("SEARCHBAR", ""), |
Member
There was a problem hiding this comment.
hg.C does only support a single argument... Did this not raise an exception? (If the value does not exists None is returned which is rendered as an empty string (i. e. not rendered).
Member
There was a problem hiding this comment.
Thinking about it: Adding support for a default value could actually make sense in some cases...
Contributor
Author
There was a problem hiding this comment.
hg.Cdoes only support a single argument... Did this not raise an exception? (If the value does not existsNoneis returned which is rendered as an empty string (i. e. not rendered).
fixed it, thanks.
saemideluxe
approved these changes
Aug 31, 2021
wipascal
deleted the
feature/hide-searchbar-if-user-not-authenticated
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.