Conversation
Co-Authored-By: Cornelius-G <Cornelius-G@users.noreply.github.com>
This reverts commit 9cbacf2.
|
Can you check the CI error on Julia 1? |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
- Coverage 55.06% 49.31% -5.76%
==========================================
Files 116 131 +15
Lines 5619 6323 +704
==========================================
+ Hits 3094 3118 +24
- Misses 2525 3205 +680
☔ View full report in Codecov by Sentry. |
|
I've updated this to use the new BATContext. "transformed_example.jl" doesn't fully run through, but I'm not sure if that's related. |
|
in the example doesn't work yet, but that's to be expected currently, right? I think |
Hm, for me this line works. As it should, because that is just the "good old" HMC smapling, not using the new transformations. |
|
Ah - well, in any case, I think the adaption to BATContext is complete. |
| # this function is called once after each tuning cycle | ||
| g_state = nothing | ||
| function tuning_update!(tuner::TransformedProposalCovTuner, chain::MCMCIterator, samples::DensitySampleVector) | ||
| function tuning_update!(tuner::TransformedProposalCovTuner, chain::TransformedMCMCIterator, samples::DensitySampleVector) |
There was a problem hiding this comment.
I guess we need to revert this change, because the CI tests fail due to this line.
TransformedMCMCIterator is a subtype of MCMCIterator. Dispatch should be fine just using the tuner argument.
There was a problem hiding this comment.
Sure, we can revert it. But why does it cause errors? For a TransformedProposalCovTuner the chain must be a TransformedMCMCIterator, right?
|
@Micki-D needs to be updated to API changes. |
|
Closing in favor of #441 |
3 participants
FYI
@oschulz @Cornelius-G