Skip to content

IBDP: do less work by directly computing size#8905

Merged
dhalperi merged 1 commit intomasterfrom
spr/master/95482b30
Dec 20, 2023
Merged

IBDP: do less work by directly computing size#8905
dhalperi merged 1 commit intomasterfrom
spr/master/95482b30

Conversation

@dhalperi
Copy link
Copy Markdown
Member

@dhalperi dhalperi commented Dec 20, 2023

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 20, 2023

Codecov Report

Merging #8905 (64065ba) into master (90aacc8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8905      +/-   ##
==========================================
- Coverage   72.51%   72.50%   -0.02%     
==========================================
  Files        3319     3319              
  Lines      169420   169421       +1     
  Branches    19878    19878              
==========================================
- Hits       122854   122837      -17     
- Misses      37420    37435      +15     
- Partials     9146     9149       +3     
Files Coverage Δ
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 84.66% <100.00%> (ø)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 88.48% <100.00%> (ø)
...rc/main/java/org/batfish/dataplane/rib/BgpRib.java 90.04% <100.00%> (+0.04%) ⬆️

... and 5 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@SLarkworthy SLarkworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @anothermattbrown and @progwriter)

@dhalperi dhalperi merged commit b84499d into master Dec 20, 2023
@dhalperi dhalperi deleted the spr/master/95482b30 branch December 20, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants