Skip to content

BgpProcess: only sort maps for JSON APIs#8907

Merged
dhalperi merged 1 commit intomasterfrom
spr/master/280d2500
Dec 20, 2023
Merged

BgpProcess: only sort maps for JSON APIs#8907
dhalperi merged 1 commit intomasterfrom
spr/master/280d2500

Conversation

@dhalperi
Copy link
Copy Markdown
Member

@dhalperi dhalperi commented Dec 20, 2023

And make them immutable at conversion time to save space.

@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

@dhalperi dhalperi force-pushed the spr/master/280d2500 branch from 2ec1327 to d3f63d0 Compare December 20, 2023 09:28
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 20, 2023

Codecov Report

Merging #8907 (d3f63d0) into master (90aacc8) will decrease coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head d3f63d0 differs from pull request most recent head d61f6e8. Consider uploading reports for the commit d61f6e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8907      +/-   ##
==========================================
- Coverage   72.51%   72.50%   -0.02%     
==========================================
  Files        3319     3319              
  Lines      169420   169432      +12     
  Branches    19878    19880       +2     
==========================================
- Hits       122854   122845       -9     
- Misses      37420    37437      +17     
- Partials     9146     9150       +4     
Files Coverage Δ
...rc/main/java/org/batfish/datamodel/BgpProcess.java 83.60% <100.00%> (+0.27%) ⬆️
.../org/batfish/dataplane/ibdp/BgpRoutingProcess.java 84.66% <100.00%> (ø)
...java/org/batfish/dataplane/ibdp/VirtualRouter.java 88.23% <100.00%> (-0.26%) ⬇️
...rc/main/java/org/batfish/dataplane/rib/BgpRib.java 90.04% <100.00%> (+0.04%) ⬆️
.../java/org/batfish/job/ConvertConfigurationJob.java 88.19% <100.00%> (+0.16%) ⬆️

... and 5 files with indirect coverage changes

@dhalperi dhalperi requested a review from SLarkworthy December 20, 2023 16:09
Copy link
Copy Markdown
Contributor

@SLarkworthy SLarkworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 5 files reviewed, all discussions resolved

Copy link
Copy Markdown
Contributor

@SLarkworthy SLarkworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

@dhalperi dhalperi force-pushed the spr/master/16f5cd36 branch from 7eb79f6 to 693e066 Compare December 20, 2023 18:33
@dhalperi dhalperi force-pushed the spr/master/280d2500 branch from d3f63d0 to dcce072 Compare December 20, 2023 18:33
Base automatically changed from spr/master/16f5cd36 to master December 20, 2023 18:33
And make them immutable at conversion time to save space.

commit-id:280d2500
@dhalperi dhalperi force-pushed the spr/master/280d2500 branch from dcce072 to d61f6e8 Compare December 20, 2023 18:34
@dhalperi dhalperi merged commit 4027c9f into master Dec 20, 2023
@dhalperi dhalperi deleted the spr/master/280d2500 branch December 20, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants