BgpProcess: only sort maps for JSON APIs#8907
Merged
Conversation
This was referenced Dec 20, 2023
2ec1327 to
d3f63d0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8907 +/- ##
==========================================
- Coverage 72.51% 72.50% -0.02%
==========================================
Files 3319 3319
Lines 169420 169432 +12
Branches 19878 19880 +2
==========================================
- Hits 122854 122845 -9
- Misses 37420 37437 +17
- Partials 9146 9150 +4
|
SLarkworthy
reviewed
Dec 20, 2023
Contributor
SLarkworthy
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 5 files reviewed, all discussions resolved
SLarkworthy
reviewed
Dec 20, 2023
Contributor
SLarkworthy
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
7eb79f6 to
693e066
Compare
d3f63d0 to
dcce072
Compare
And make them immutable at conversion time to save space. commit-id:280d2500
dcce072 to
d61f6e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And make them immutable at conversion time to save space.