Junos: flesh out more tunnel grammar, specifically destination-udp-port#9238
Merged
Junos: flesh out more tunnel grammar, specifically destination-udp-port#9238
Conversation
This was referenced Oct 8, 2024
commit-id:4c71b233
ca15d66 to
e8574ba
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9238 +/- ##
==========================================
- Coverage 72.73% 72.72% -0.01%
==========================================
Files 3314 3314
Lines 170017 170025 +8
Branches 20046 20046
==========================================
- Hits 123658 123655 -3
- Misses 37197 37207 +10
- Partials 9162 9163 +1
|
SLarkworthy
reviewed
Oct 8, 2024
Contributor
SLarkworthy
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhalperi)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: