Skip to content

Junos: slightly more generous BMP station logic#9239

Merged
dhalperi merged 2 commits intomasterfrom
spr/master/4d3d2f5d
Oct 8, 2024
Merged

Junos: slightly more generous BMP station logic#9239
dhalperi merged 2 commits intomasterfrom
spr/master/4d3d2f5d

Conversation

@dhalperi
Copy link
Copy Markdown
Member

@dhalperi dhalperi commented Oct 8, 2024

Handle lines with multiple final commands on the same line


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@batfish-bot
Copy link
Copy Markdown

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (e3a110c) to head (e15dab8).
Report is 54 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9239      +/-   ##
==========================================
- Coverage   72.73%   72.72%   -0.01%     
==========================================
  Files        3314     3314              
  Lines      170017   170025       +8     
  Branches    20046    20046              
==========================================
+ Hits       123658   123659       +1     
- Misses      37197    37206       +9     
+ Partials     9162     9160       -2     
Files with missing lines Coverage Δ
...fish/grammar/flatjuniper/ConfigurationBuilder.java 69.46% <100.00%> (+0.06%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@SLarkworthy SLarkworthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dhalperi)

Handle lines with multiple final commands on the same line

commit-id:4d3d2f5d
@dhalperi dhalperi force-pushed the spr/master/4c71b233 branch from ca15d66 to e8574ba Compare October 8, 2024 17:38
@dhalperi dhalperi force-pushed the spr/master/4d3d2f5d branch from edccd4d to e15dab8 Compare October 8, 2024 17:38
Base automatically changed from spr/master/4c71b233 to master October 8, 2024 18:18
@dhalperi dhalperi merged commit 58d3139 into master Oct 8, 2024
@dhalperi dhalperi deleted the spr/master/4d3d2f5d branch October 8, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants