Closed
Conversation
In upcoming changes, we'd like to have the ability to use C++17 features. This ensures that such code will build successfully on the various CI platforms, regardless of the C++ standard version the compiler defaults to.
meteorcloudy
approved these changes
Nov 13, 2023
Member
|
Should we backport this to 7.0.0? |
Contributor
Author
|
@bazel-io fork 7.0.0 I see no downside to backporting. |
tjgq
added
the
awaiting-PR-merge
Member
|
Yeah, we need to backport to 7.0.0 if we want to include output service server code in 7.x later. |
Member
|
@bazel-io fork 7.0.0 |
keertk
added
the
team-OSS
github-actions
Bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Nov 13, 2023
In upcoming changes, we'd like to have the ability to use C++17 features. This ensures that such code will build successfully on the various CI platforms, regardless of the C++ standard version the compiler defaults to. Closes bazelbuild#20085. PiperOrigin-RevId: 581952933 Change-Id: I0753249e2182b3ab499bc91a384ad93ec59d65f8
keertk
pushed a commit
that referenced
this pull request
Nov 13, 2023
In upcoming changes, we'd like to have the ability to use C++17 features. This ensures that such code will build successfully on the various CI platforms, regardless of the C++ standard version the compiler defaults to. Closes #20085. Commit ba38aa2 PiperOrigin-RevId: 581952933 Change-Id: I0753249e2182b3ab499bc91a384ad93ec59d65f8 Co-authored-by: Tiago Quelhas <tjgq@google.com>
Member
|
The changes in this PR have been included in Bazel 7.0.0 RC5. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In upcoming changes, we'd like to have the ability to use C++17 features.
This ensures that such code will build successfully on the various CI
platforms, regardless of the C++ standard version the compiler defaults to.