[7.0.0] Build Bazel with C++17.#20174
Merged
keertk merged 1 commit intobazelbuild:release-7.0.0from Nov 13, 2023
Merged
Conversation
In upcoming changes, we'd like to have the ability to use C++17 features. This ensures that such code will build successfully on the various CI platforms, regardless of the C++ standard version the compiler defaults to. Closes bazelbuild#20085. PiperOrigin-RevId: 581952933 Change-Id: I0753249e2182b3ab499bc91a384ad93ec59d65f8
bazel-io
added
team-OSS
github-actions
Bot
removed
the
awaiting-review
coeuvre
approved these changes
Nov 13, 2023
github-actions
Bot
removed
the
awaiting-review
lucamilanesio
pushed a commit
to GerritCodeReview/gerrit
that referenced
this pull request
Dec 12, 2023
Also update C++-toolchain to use modern C++ features. This is only relevant for dependencies, that are built from source, like Protobuf and other transitive dependencies (e.g. abseil-cpp). We are doing this to synchronize with the Bazel itself, that bumped C++ toolchain in 7.x release line. The original commit message in this PR: [1]: In upcoming changes, we'd like to have the ability to use C++17 features. This ensures that such code will build successfully on the various CI platforms, regardless of the C++ standard version the compiler defaults to. [1] bazelbuild/bazel#20174 Release-Notes: Update Bazel version to 7.0.0 Change-Id: Ie7cb3003da7b9b49100a60c401253eb999dcb6d5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In upcoming changes, we'd like to have the ability to use C++17 features.
This ensures that such code will build successfully on the various CI
platforms, regardless of the C++ standard version the compiler defaults to.
Closes #20085.
Commit ba38aa2
PiperOrigin-RevId: 581952933
Change-Id: I0753249e2182b3ab499bc91a384ad93ec59d65f8