[7.4.0] Propagate linkopts of header-only libraries to cc_shared_library#24017
Merged
Conversation
Fixes bazelbuild#21884 Fixes bazelbuild#23053 Closes bazelbuild#23215. PiperOrigin-RevId: 686518093 Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1
iancha1992
added
team-Rules-CPP
iancha1992
changed the title
linkopts of header-only libraries to cc_shared_librarylinkopts of header-only libraries to cc_shared_library
meteorcloudy
approved these changes
Oct 17, 2024
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21884
Fixes #23053
Closes #23215.
PiperOrigin-RevId: 686518093
Change-Id: I1a6699b169fe4291ad0dda3be7e74f38c8e37bf1
Commit 0fdb36f