[7.4.1] Revert "[7.4.0] Propagate linkopts of header-only libraries to cc_shared_library"#24087
Merged
Merged
Conversation
github-actions
Bot
added
the
awaiting-review
Member
|
@fmeum could you please send one to Edit: Nevermind.. I changed the base to |
github-actions
Bot
removed
the
awaiting-review
iancha1992
changed the title
linkopts of header-only libraries to cc_shared_library"linkopts of header-only libraries to cc_shared_library"
github-actions
Bot
added
the
awaiting-review
pzembrod
approved these changes
Oct 25, 2024
pzembrod
added
awaiting-PR-merge
Collaborator
Author
|
@pzembrod As this is a cherry-pick, you can merge it directly via the merge button. |
…shared_l…" This reverts commit c118308.
fmeum
force-pushed
the
revert-24017-cp23588
branch
from
a647fe8 to
43d0c71
Compare
github-actions
Bot
removed
the
awaiting-PR-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #24017
The change has broken multiple existing builds. Even if it can be fixed, its usefulness does not justify the potential for more breakages in a minor release.