Reduce Merkle tree footprint by referencing FileArtifactValue#28739
Closed
fmeum wants to merge 1 commit intobazelbuild:masterfrom
Closed
Reduce Merkle tree footprint by referencing FileArtifactValue#28739fmeum wants to merge 1 commit intobazelbuild:masterfrom
FileArtifactValue#28739fmeum wants to merge 1 commit intobazelbuild:masterfrom
Conversation
fmeum
force-pushed
the
optimize-merkle-tree-size-3
branch
from
06600c5 to
149c68c
Compare
Collaborator
Author
|
@bazel-io fork 9.1.0 |
fmeum
force-pushed
the
optimize-merkle-tree-size-3
branch
from
149c68c to
cba87f9
Compare
github-actions
bot
added
team-Remote-Exec
tjgq
approved these changes
Mar 5, 2026
tjgq
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Mar 6, 2026
…lbuild#28739) For regular files, use `FileArtifactValue`s instead of `Digest`s as the keys in the Merkle tree's blob map. The former are retained anyway, the latter are unique per tree. Also describe the remaining footprint of `MerkleTree` and ideas for future improvements. Work towards bazelbuild#20478 Work towards bazelbuild#28734 No - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). RELNOTES: None Closes bazelbuild#28739. PiperOrigin-RevId: 879654674 Change-Id: I87fc74392481a7409f3775c27d90eab8b5eb1b4b
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
…e` (http… (#28918) …s://github.com//pull/28739) For regular files, use `FileArtifactValue`s instead of `Digest`s as the keys in the Merkle tree's blob map. The former are retained anyway, the latter are unique per tree. Also describe the remaining footprint of `MerkleTree` and ideas for future improvements. Work towards #20478 Work towards #28734 No - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). RELNOTES: None Closes #28739. PiperOrigin-RevId: 879654674 Change-Id: I87fc74392481a7409f3775c27d90eab8b5eb1b4b <!-- Thank you for contributing to Bazel! Please read the contribution guidelines: https://bazel.build/contribute.html --> ### Description <!-- Please provide a brief summary of the changes in this PR. --> ### Motivation <!-- Why is this change important? Does it fix a specific bug or add a new feature? If this PR fixes an existing issue, please link it here (e.g. "Fixes #1234"). --> ### Build API Changes <!-- Does this PR affect the Build API? (e.g. Starlark API, providers, command-line flags, native rules) If yes, please answer the following: 1. Has this been discussed in a design doc or issue? (Please link it) 2. Is the change backward compatible? 3. If it's a breaking change, what is the migration plan? --> No ### Checklist - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). ### Release Notes <!-- If this is a new feature, please add 'RELNOTES[NEW]: <description>' here. If this is a breaking change, please add 'RELNOTES[INC]: <reason>' here. If this change should be mentioned in release notes, please add 'RELNOTES: <reason>' here. --> RELNOTES: None Commit bbdc0c3 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For regular files, use
FileArtifactValues instead ofDigests as the keys in the Merkle tree's blob map. The former are retained anyway, the latter are unique per tree.Also describe the remaining footprint of
MerkleTreeand ideas for future improvements.Motivation
Work towards #20478
Work towards #28734
Build API Changes
No
Checklist
Release Notes
RELNOTES: None