Skip to content

[9.1.0] Reduce Merkle tree footprint by referencing FileArtifactValue (http…#28918

Merged
iancha1992 merged 1 commit intobazelbuild:release-9.1.0from
iancha1992:cp28825
Mar 10, 2026
Merged

[9.1.0] Reduce Merkle tree footprint by referencing FileArtifactValue (http…#28918
iancha1992 merged 1 commit intobazelbuild:release-9.1.0from
iancha1992:cp28825

Conversation

@iancha1992
Copy link
Copy Markdown
Member

…s://github.com//pull/28739)

For regular files, use FileArtifactValues instead of Digests as the keys in the Merkle tree's blob map. The former are retained anyway, the latter are unique per tree.

Also describe the remaining footprint of MerkleTree and ideas for future improvements.

Work towards #20478
Work towards #28734

No

  • I have added tests for the new use cases (if any).
  • I have updated the documentation (if applicable).

RELNOTES: None

Closes #28739.

PiperOrigin-RevId: 879654674
Change-Id: I87fc74392481a7409f3775c27d90eab8b5eb1b4b

Description

Motivation

Build API Changes

No

Checklist

  • I have added tests for the new use cases (if any).
  • I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

Commit bbdc0c3

…lbuild#28739)

For regular files, use `FileArtifactValue`s instead of `Digest`s as the keys in the Merkle tree's blob map. The former are retained anyway, the latter are unique per tree.

Also describe the remaining footprint of `MerkleTree` and ideas for future improvements.

Work towards bazelbuild#20478
Work towards bazelbuild#28734

No

- [ ] I have added tests for the new use cases (if any).
- [ ] I have updated the documentation (if applicable).

RELNOTES: None

Closes bazelbuild#28739.

PiperOrigin-RevId: 879654674
Change-Id: I87fc74392481a7409f3775c27d90eab8b5eb1b4b
@iancha1992 iancha1992 requested a review from a team as a code owner March 6, 2026 19:35
@iancha1992 iancha1992 added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Mar 6, 2026
@iancha1992 iancha1992 requested review from coeuvre and tjgq March 6, 2026 19:35
@iancha1992 iancha1992 enabled auto-merge March 6, 2026 19:36
@iancha1992 iancha1992 added this pull request to the merge queue Mar 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 10, 2026
@iancha1992 iancha1992 added this pull request to the merge queue Mar 10, 2026
Merged via the queue into bazelbuild:release-9.1.0 with commit 3920a9b Mar 10, 2026
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants