Skip to content

[9.0.1] Refactor flag aliases to be passed around as labels#28835

Merged
iancha1992 merged 3 commits intobazelbuild:release-9.0.1from
gregestren:release-9.0.1
Mar 2, 2026
Merged

[9.0.1] Refactor flag aliases to be passed around as labels#28835
iancha1992 merged 3 commits intobazelbuild:release-9.0.1from
gregestren:release-9.0.1

Conversation

@gregestren
Copy link
Contributor

@gregestren gregestren commented Feb 27, 2026

Manual cherrypick of #28506. Fixes #28834.

RELNOTES: None

…ld#28506)

This avoids intermediate ad-hoc label parsing and stringification. It also makes it easier to reason about the involved types as they are no longer maps or pairs of `String`.

Also adds a test to verify that flag aliases pointing into external repos correctly parse apparent repo names.

Closes bazelbuild#28506.

PiperOrigin-RevId: 872091265
Change-Id: I5366a15b0f0ff5fa81eb00b7323242393f9c2251
@gregestren gregestren requested a review from a team as a code owner February 27, 2026 21:50
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Feb 27, 2026
@gregestren gregestren changed the title [9.0.1] Refactor flag aliases to be passed around as labels (https://… [9.0.1] Refactor flag aliases to be passed around as labels Feb 27, 2026
@gregestren
Copy link
Contributor Author

@fmeum

@iancha1992 iancha1992 added this pull request to the merge queue Mar 2, 2026
Merged via the queue into bazelbuild:release-9.0.1 with commit 290d0fe Mar 2, 2026
45 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Mar 2, 2026
github-merge-queue bot pushed a commit that referenced this pull request Mar 2, 2026
Manual cherrypick of #28506,
copied from #28835. Fixes
#28833.

RELNOTEs: None

---------

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Configurability platforms, toolchains, cquery, select(), config transitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants