Skip to content

[9.1.0] Refactor flag aliases to be passed around as labels#28851

Merged
iancha1992 merged 3 commits intobazelbuild:release-9.1.0from
gregestren:release-9.1.0
Mar 2, 2026
Merged

[9.1.0] Refactor flag aliases to be passed around as labels#28851
iancha1992 merged 3 commits intobazelbuild:release-9.1.0from
gregestren:release-9.1.0

Conversation

@gregestren
Copy link
Contributor

Manual cherrypick of #28506, copied from #28835. Fixes #28833.

RELNOTEs: None

@gregestren gregestren requested a review from a team as a code owner March 2, 2026 18:36
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Mar 2, 2026
@gregestren gregestren changed the title [91.0] Refactor flag aliases to be passed around as labels (https://… [9.1.0] Refactor flag aliases to be passed around as labels Mar 2, 2026
@gregestren gregestren requested a review from aranguyen March 2, 2026 18:37
@iancha1992 iancha1992 enabled auto-merge March 2, 2026 19:06
@iancha1992 iancha1992 added this pull request to the merge queue Mar 2, 2026
@gregestren gregestren closed this Mar 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a manual request Mar 2, 2026
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Mar 2, 2026
fmeum and others added 3 commits March 2, 2026 20:08
…ld#28506)

This avoids intermediate ad-hoc label parsing and stringification. It also makes it easier to reason about the involved types as they are no longer maps or pairs of `String`.

Also adds a test to verify that flag aliases pointing into external repos correctly parse apparent repo names.

Closes bazelbuild#28506.

PiperOrigin-RevId: 872091265
Change-Id: I5366a15b0f0ff5fa81eb00b7323242393f9c2251
@gregestren gregestren reopened this Mar 2, 2026
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Mar 2, 2026
@gregestren gregestren added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Mar 2, 2026
@iancha1992 iancha1992 added this pull request to the merge queue Mar 2, 2026
Merged via the queue into bazelbuild:release-9.1.0 with commit 897af16 Mar 2, 2026
46 checks passed
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Configurability platforms, toolchains, cquery, select(), config transitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants